Skip to content

Commit 2627335

Browse files
nxpfrankligregkh
authored andcommitted
usb: cdns3: fix incorrect calculation of ep_buf_size when more than one config
Previously, the cdns3_gadget_check_config() function in the cdns3 driver mistakenly calculated the ep_buf_size by considering only one configuration's endpoint information because "claimed" will be clear after call usb_gadget_check_config(). The fix involves checking the private flags EP_CLAIMED instead of relying on the "claimed" flag. Fixes: dce4944 ("usb: cdns3: allocate TX FIFO size according to composite EP number") Cc: stable <stable@kernel.org> Reported-by: Ravi Gunasekaran <r-gunasekaran@ti.com> Signed-off-by: Frank Li <Frank.Li@nxp.com> Acked-by: Peter Chen <peter.chen@kernel.org> Tested-by: Ravi Gunasekaran <r-gunasekaran@ti.com> Link: https://lore.kernel.org/r/20230707230015.494999-2-Frank.Li@nxp.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f4fc01a commit 2627335

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/usb/cdns3/cdns3-gadget.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3015,12 +3015,14 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
30153015
static int cdns3_gadget_check_config(struct usb_gadget *gadget)
30163016
{
30173017
struct cdns3_device *priv_dev = gadget_to_cdns3_device(gadget);
3018+
struct cdns3_endpoint *priv_ep;
30183019
struct usb_ep *ep;
30193020
int n_in = 0;
30203021
int total;
30213022

30223023
list_for_each_entry(ep, &gadget->ep_list, ep_list) {
3023-
if (ep->claimed && (ep->address & USB_DIR_IN))
3024+
priv_ep = ep_to_cdns3_ep(ep);
3025+
if ((priv_ep->flags & EP_CLAIMED) && (ep->address & USB_DIR_IN))
30243026
n_in++;
30253027
}
30263028

0 commit comments

Comments
 (0)