Skip to content

Commit f4fc01a

Browse files
nxpfrankligregkh
authored andcommitted
usb: gadget: call usb_gadget_check_config() to verify UDC capability
The legacy gadget driver omitted calling usb_gadget_check_config() to ensure that the USB device controller (UDC) has adequate resources, including sufficient endpoint numbers and types, to support the given configuration. Previously, usb_add_config() was solely invoked by the legacy gadget driver. Adds the necessary usb_gadget_check_config() after the bind() operation to fix the issue. Fixes: dce4944 ("usb: cdns3: allocate TX FIFO size according to composite EP number") Cc: stable <stable@kernel.org> Reported-by: Ravi Gunasekaran <r-gunasekaran@ti.com> Signed-off-by: Frank Li <Frank.Li@nxp.com> Link: https://lore.kernel.org/r/20230707230015.494999-1-Frank.Li@nxp.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 609fded commit f4fc01a

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/usb/gadget/composite.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1125,6 +1125,10 @@ int usb_add_config(struct usb_composite_dev *cdev,
11251125
goto done;
11261126

11271127
status = bind(config);
1128+
1129+
if (status == 0)
1130+
status = usb_gadget_check_config(cdev->gadget);
1131+
11281132
if (status < 0) {
11291133
while (!list_empty(&config->functions)) {
11301134
struct usb_function *f;

0 commit comments

Comments
 (0)