Skip to content

Commit 20bcc28

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: omapfb/tfp410: Don't put .remove() in .exit.text and drop suppress_bind_attrs
On today's platforms the memory savings of putting the remove function in .exit isn't that relevant any more. It only matters for built-in drivers and typically saves a few 100k. The downside is that the driver cannot be unbound at runtime which is ancient and also slightly complicates testing. Also it requires to mark the driver struct with __refdata which is needed to suppress a (W=1) modpost warning: WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410: section mismatch in reference: tfp410_driver+0x4 (section: .data) -> tfp410_remove (section: .exit.text) To simplify matters, move the remove callback to .text and drop .suppress_bind_attrs = true. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 6a06fc7 commit 20bcc28

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ static int tfp410_probe(struct platform_device *pdev)
217217
return r;
218218
}
219219

220-
static int __exit tfp410_remove(struct platform_device *pdev)
220+
static int tfp410_remove(struct platform_device *pdev)
221221
{
222222
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
223223
struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -247,11 +247,10 @@ MODULE_DEVICE_TABLE(of, tfp410_of_match);
247247

248248
static struct platform_driver tfp410_driver = {
249249
.probe = tfp410_probe,
250-
.remove = __exit_p(tfp410_remove),
250+
.remove = tfp410_remove,
251251
.driver = {
252252
.name = "tfp410",
253253
.of_match_table = tfp410_of_match,
254-
.suppress_bind_attrs = true,
255254
},
256255
};
257256

0 commit comments

Comments
 (0)