Skip to content

Commit 1391b9c

Browse files
dceraolorodrigovivi
authored andcommitted
drm/i915/guc: ADL-N should use the same GuC FW as ADL-S
The only difference between the ADL S and P GuC FWs is the HWConfig support. ADL-N does not support HWConfig, so we should use the same binary as ADL-S, otherwise the GuC might attempt to fetch a config table that does not exist. ADL-N is internally identified as an ADL-P, so we need to special-case it in the FW selection code. Fixes: 7e28d0b ("drm/i915/adl-n: Enable ADL-N platform") Cc: John Harrison <John.C.Harrison@Intel.com> Cc: Tejas Upadhyay <tejas.upadhyay@intel.com> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com> Cc: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220621233005.3952293-1-daniele.ceraolospurio@intel.com (cherry picked from commit 971e4a9) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 046cd8a commit 1391b9c

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,15 @@ __uc_fw_auto_select(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw)
162162
u8 rev = INTEL_REVID(i915);
163163
int i;
164164

165+
/*
166+
* The only difference between the ADL GuC FWs is the HWConfig support.
167+
* ADL-N does not support HWConfig, so we should use the same binary as
168+
* ADL-S, otherwise the GuC might attempt to fetch a config table that
169+
* does not exist.
170+
*/
171+
if (IS_ADLP_N(i915))
172+
p = INTEL_ALDERLAKE_S;
173+
165174
GEM_BUG_ON(uc_fw->type >= ARRAY_SIZE(blobs_all));
166175
fw_blobs = blobs_all[uc_fw->type].blobs;
167176
fw_count = blobs_all[uc_fw->type].count;

0 commit comments

Comments
 (0)