Skip to content

Commit 046cd8a

Browse files
HBh25Yrodrigovivi
authored andcommitted
drm/i915: fix a possible refcount leak in intel_dp_add_mst_connector()
If drm_connector_init fails, intel_connector_free will be called to take care of proper free. So it is necessary to drop the refcount of port before intel_connector_free. Fixes: 091a4f9 ("drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector") Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Reviewed-by: José Roberto de Souza <jose.souza@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220624130406.17996-1-jose.souza@intel.com Signed-off-by: José Roberto de Souza <jose.souza@intel.com> (cherry picked from commit cea9ed6) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 3234649 commit 046cd8a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/i915/display/intel_dp_mst.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -839,6 +839,7 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo
839839
ret = drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs,
840840
DRM_MODE_CONNECTOR_DisplayPort);
841841
if (ret) {
842+
drm_dp_mst_put_port_malloc(port);
842843
intel_connector_free(intel_connector);
843844
return NULL;
844845
}

0 commit comments

Comments
 (0)