Skip to content

Commit 1113501

Browse files
lumagandersson
authored andcommitted
clk: qcom: dispcc-sm6350: fix DisplayPort clocks
On SM6350 DisplayPort link clocks use frequency tables inherited from the vendor kernel, it is not applicable in the upstream kernel. Drop frequency tables and use clk_byte2_ops for those clocks. This fixes frequency selection in the OPP core (which otherwise attempts to use invalid 810 KHz as DP link rate), also fixing the following message: msm-dp-display ae90000.displayport-controller: _opp_config_clk_single: failed to set clock rate: -22 Fixes: 8375197 ("clk: qcom: Add display clock controller driver for SM6350") Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Tested-by: Luca Weiss <luca.weiss@fairphone.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20240424-dispcc-dp-clocks-v2-2-b44038f3fa96@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent e801038 commit 1113501

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

drivers/clk/qcom/dispcc-sm6350.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -221,26 +221,17 @@ static struct clk_rcg2 disp_cc_mdss_dp_crypto_clk_src = {
221221
},
222222
};
223223

224-
static const struct freq_tbl ftbl_disp_cc_mdss_dp_link_clk_src[] = {
225-
F(162000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0),
226-
F(270000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0),
227-
F(540000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0),
228-
F(810000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0),
229-
{ }
230-
};
231-
232224
static struct clk_rcg2 disp_cc_mdss_dp_link_clk_src = {
233225
.cmd_rcgr = 0x10f8,
234226
.mnd_width = 0,
235227
.hid_width = 5,
236228
.parent_map = disp_cc_parent_map_0,
237-
.freq_tbl = ftbl_disp_cc_mdss_dp_link_clk_src,
238229
.clkr.hw.init = &(struct clk_init_data){
239230
.name = "disp_cc_mdss_dp_link_clk_src",
240231
.parent_data = disp_cc_parent_data_0,
241232
.num_parents = ARRAY_SIZE(disp_cc_parent_data_0),
242233
.flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
243-
.ops = &clk_rcg2_ops,
234+
.ops = &clk_byte2_ops,
244235
},
245236
};
246237

0 commit comments

Comments
 (0)