Add Rect::origin and update Rect::new to specify the origin location of rectangles.
#1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a white line before and after the function you added to make it consistent with the rest, otherwise looks good. |
jagprog5
reviewed
Jul 11, 2025
src/sdl2/rect.rs
Outdated
| @@ -12,7 +12,7 @@ use std::ptr; | |||
|
|
|||
| /// The maximal integer value that can be used for rectangles. | |||
| /// | |||
| /// This value is smaller than strictly needed, but is useful in ensuring that | |||
| /// This value is smaller than st isrictly needed, but is useful in ensuring that | |||
|
Fixed the typo as well as a formatting issue I introduced in the Changelog file. Apologies for the collateral damage from editing on mobile 😅 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers #1492
The goal is to ensure the origin location is understood and made available to users, as this point is used as a basis for transformations and positioning. Would work in stride with
Rect::center.