Skip to content

update readme and fix CI problem with .NET SDK version #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2025
Merged

Conversation

chtenb
Copy link
Member

@chtenb chtenb commented Jun 2, 2025

Fixes #102

@chtenb chtenb changed the title update readme update readme and fix CI problem with .NET SDK version Jun 2, 2025
@chtenb chtenb requested a review from Copilot June 2, 2025 13:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README documentation and fixes CI issues by setting the .NET SDK version to 8.0.0. Additionally, minor comment formatting adjustments and new build targets have been introduced to improve code consistency and workflow setup.

  • Updated CI workflows to use actions/setup-dotnet@v4 with .NET 8.0 SDK.
  • Updated global.json to specify the .NET SDK version as 8.0.0.
  • Made comment formatting improvements and added a tutorial width check in the justfile.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
justfile Added a new target (check-tutorial-width) using awk to enforce a maximum line length for Tutorial.cs.
global.json Updated the .NET SDK version to 8.0.0.
Rubjerg.Graphviz.Test/Tutorial.cs Improved comment formatting; modified SVG output filename in layout tests.
README.md & README-src.md Revised wording and formatting for clarity regarding precompiled binaries and dependencies.
.github/workflows/* Upgraded workflow steps to use actions/setup-dotnet@v4 and standardized .NET SDK version configuration.
.editorconfig Added settings for Tutorial.cs to enforce a max line length of 100 characters.
Comments suppressed due to low confidence (2)

Rubjerg.Graphviz.Test/Tutorial.cs:79

  • Ensure that renaming the SVG output file from '/dot_out.svg' to '/dot.svg' is intentional and that any dependent tests or file references have been updated accordingly.
root.ToSvgFile(TestContext.CurrentContext.TestDirectory + "/dot.svg");

.editorconfig:215

  • [nitpick] Confirm that the max_line_length of 100 for Tutorial.cs aligns with the project's overall style guidelines and code readability standards.
max_line_length = 100

@chtenb chtenb merged commit 2ed1576 into master Jun 2, 2025
6 checks passed
@chtenb chtenb deleted the readme branch June 2, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the readme tutorial not scroll horizontally
1 participant