Skip to content

Conversation

@Maosghoul
Copy link

@Maosghoul Maosghoul commented Oct 25, 2025

Related GitHub Issue

Issue: #8818

Description

Add MiniMax as a new provider to enable users to leverage the RooCode plugin for coding, reasoning, and other AI-assisted development tasks using the MiniMax-M2 model.

Provider Details:

These models provide an excellent alternative for users seeking high-quality AI assistance with competitive pricing, especially for Chinese language tasks and general programming assistance.
The implementation follows the established provider pattern used by other providers like Doubao, ensuring consistency with the existing codebase architecture.

Test Procedure

I have thoroughly tested this implementation:

  1. API Integration: Select MiniMax provider and added MiniMax API key and successfully connected to the service using OpenAI-compatible endpoints
  2. Model Selection: MiniMax-M2 is selectable and functional
  3. Chat Functionality: Tested chat interactions with both models - they respond appropriately to coding requests and general queries
  4. UI Integration: Confirmed the MiniMax provider appears correctly in the provider dropdown with proper API key validation
  5. Build Validation: Full build passes (npm run package) with no errors or warnings
  6. Press F5 to start

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Clipboard_Screenshot_1761389050 Clipboard_Screenshot_1761389210

Documentation Updates

No documentation updates are required.

Additional Notes

Implementation follows the same architectural pattern as existing providers (Doubao,Zai, OpenAI, etc.)

Get in Touch

Maosghoul


Important

Add MiniMax provider with MiniMax-M2 model for AI-assisted tasks, including API handling, UI integration, and localization updates.

  • Provider Integration:
    • Add MiniMax provider with MiniMax-M2 model in minimax.ts.
    • Update provider-settings.ts and global-settings.ts to include minimax configurations.
    • Implement MiniMaxHandler in minimax.ts for API interactions.
  • UI Components:
    • Add MiniMax component in providers/MiniMax.tsx for settings UI.
    • Update ApiOptions.tsx to include MiniMax in provider dropdown.
  • Testing:
    • Add minimax.spec.ts for testing MiniMaxHandler functionality.
  • Localization:
    • Update localization files to include MiniMax related strings in multiple languages.

This description was created by Ellipsis for 8cd9e53. You can customize this summary. It will automatically update as commits are pushed.

@Maosghoul Maosghoul requested review from cte, jr and mrubens as code owners October 25, 2025 10:47
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Oct 25, 2025
@roomote
Copy link

roomote bot commented Oct 25, 2025

Issues to Fix

  • Test assertions don't match model configuration: Lines 83-84 expect contextWindow: 1_000_192 and maxTokens: 25_600, but the model definition specifies contextWindow: 192_000 and maxTokens: 128_000
  • Test assertions have incorrect pricing: Lines 274-279 expect inputPrice: 0.4 and outputPrice: 2.2, but the model defines inputPrice: 0.3 and outputPrice: 1.2
  • Missing API key handling: Line 133 will fail because BaseOpenAiCompatibleProvider requires an API key, but the test instantiates with empty object. Use ?? "not-provided" like Doubao and Moonshot providers

Follow Along on Roo Code Cloud

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants