Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Oct 22, 2025

Cherry-picked from commit e908d8b

This PR:

  • Sets browser tool to OFF by default
  • Hides Browser auto-approve setting when browser tool is disabled
  • Fixes dropdown dependencies

Important

Sets browser tool to be off by default and updates UI to hide browser-related options when disabled.

  • Behavior:
    • Sets browserToolEnabled to false by default in Task.ts, ClineProvider.ts, and webviewMessageHandler.ts.
    • Hides alwaysAllowBrowser option in AutoApproveDropdown.tsx and AutoApproveToggle.tsx when browserToolEnabled is false.
  • UI Components:
    • Updates AutoApproveDropdown.tsx to filter out alwaysAllowBrowser when browserToolEnabled is false.
    • Updates AutoApproveToggle.tsx to conditionally render alwaysAllowBrowser based on browserToolEnabled.
  • Tests:
    • Mocks useExtensionState in AutoApproveToggle.spec.tsx to ensure browserToolEnabled is true for testing purposes.

This description was created by Ellipsis for d04ec52. You can customize this summary. It will automatically update as commits are pushed.

@Copilot Copilot AI review requested due to automatic review settings October 22, 2025 15:53
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused labels Oct 22, 2025
@roomote
Copy link

roomote bot commented Oct 22, 2025

✅ Code Review Complete

No issues found. The changes correctly implement the following:

  1. Browser tool now defaults to OFF - All default values consistently changed from true to false
  2. Browser auto-approve hidden when disabled - UI properly filters the browser option based on browserToolEnabled state
  3. Clean implementation - Dependencies updated correctly, logic is sound

The PR is ready to merge.

Follow Along on Roo Code Cloud

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the browser tool default state from enabled to disabled and conditionally hides browser-related auto-approval settings when the browser tool is disabled.

  • Sets browserToolEnabled default value to false across multiple files
  • Filters out browser auto-approve option from UI when browser tool is disabled
  • Updates dependency arrays to include browserToolEnabled for proper reactivity

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
webview-ui/src/context/ExtensionStateContext.tsx Changes default browserToolEnabled from true to false
webview-ui/src/components/settings/AutoApproveToggle.tsx Filters browser auto-approve toggle when browser tool disabled
webview-ui/src/components/chat/AutoApproveDropdown.tsx Filters browser option from dropdown counts and Select All/None operations
src/core/webview/webviewMessageHandler.ts Updates fallback default for browserToolEnabled message to false
src/core/webview/generateSystemPrompt.ts Changes browser tool enablement check default to false
src/core/webview/ClineProvider.ts Updates two locations with browserToolEnabled default to false
src/core/task/Task.ts Changes browser tool capability check default to false

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 22, 2025
@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Oct 22, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Oct 22, 2025
Copy link
Collaborator Author

@hannesrudolph hannesrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some issues that need attention. See inline comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Status: PR [Needs Prelim Review]

Development

Successfully merging this pull request may close these issues.

2 participants