-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: default browser tool OFF by default and hide Browser auto-approve when disabled #8775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ve when disabled; fix dropdown deps
✅ Code Review CompleteNo issues found. The changes correctly implement the following:
The PR is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the browser tool default state from enabled to disabled and conditionally hides browser-related auto-approval settings when the browser tool is disabled.
- Sets
browserToolEnableddefault value tofalseacross multiple files - Filters out browser auto-approve option from UI when browser tool is disabled
- Updates dependency arrays to include
browserToolEnabledfor proper reactivity
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| webview-ui/src/context/ExtensionStateContext.tsx | Changes default browserToolEnabled from true to false |
| webview-ui/src/components/settings/AutoApproveToggle.tsx | Filters browser auto-approve toggle when browser tool disabled |
| webview-ui/src/components/chat/AutoApproveDropdown.tsx | Filters browser option from dropdown counts and Select All/None operations |
| src/core/webview/webviewMessageHandler.ts | Updates fallback default for browserToolEnabled message to false |
| src/core/webview/generateSystemPrompt.ts | Changes browser tool enablement check default to false |
| src/core/webview/ClineProvider.ts | Updates two locations with browserToolEnabled default to false |
| src/core/task/Task.ts | Changes browser tool capability check default to false |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention. See inline comments.
…es to satisfy eslint react-hooks/exhaustive-deps
…to satisfy provider dependency
Cherry-picked from commit e908d8b
This PR:
Important
Sets browser tool to be off by default and updates UI to hide browser-related options when disabled.
browserToolEnabledtofalseby default inTask.ts,ClineProvider.ts, andwebviewMessageHandler.ts.alwaysAllowBrowseroption inAutoApproveDropdown.tsxandAutoApproveToggle.tsxwhenbrowserToolEnabledisfalse.AutoApproveDropdown.tsxto filter outalwaysAllowBrowserwhenbrowserToolEnabledisfalse.AutoApproveToggle.tsxto conditionally renderalwaysAllowBrowserbased onbrowserToolEnabled.useExtensionStateinAutoApproveToggle.spec.tsxto ensurebrowserToolEnabledistruefor testing purposes.This description was created by
for d04ec52. You can customize this summary. It will automatically update as commits are pushed.