API key from Env Var support #6178
Open
+1,081
−380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
…ssage Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
hannesrudolph
added
the
Issue/PR - Triage
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
…viders Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
dosubot
bot
added
size:XXL
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| setApiKeyUseEnvVar={(value: boolean) => setApiConfigurationField("openAiNativeApiKeyUseEnvVar", value)} | ||
| apiKeyLabel={t("settings:providers.openAiNativeApiKey")} | ||
| getApiKeyUrl="https://platform.openai.com/api-keys" | ||
| getApiKeyLabel={t("settings:providers.getopenAiNativeApiKey")} |
There was a problem hiding this comment.
Typographical error: The translation key "settings:providers.getopenAiNativeApiKey" appears to have a lower-case 'o'. Should it be "settings:providers.getOpenAiNativeApiKey" to maintain consistency with other key naming?
Suggested change
| getApiKeyLabel={t("settings:providers.getopenAiNativeApiKey")} | |
| getApiKeyLabel={t("settings:providers.getOpenAiNativeApiKey")} |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
Signed-off-by: Geoff Wilson <geoff@gr-oss.io>
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #4337
Description
This PR adds support for obtaining API keys from the environment. A checkbox is added to each configuration that allows inputting an API key -- when checked, a given environment variable (eg,
OPEN_AI_API_KEY, etc) is consulted for the key and the user is not required to provide one in the configuration. Env Var key is predictable but not editable.Additionally, added an option to generate placeholder translation keys in supported locale files. Was useful in an earlier iteration but not used now (no new translations).
Test Procedure
I tested this using VS Code run configurations, where the expected environment variable could be provided or omitted.
Pre-Submission Checklist
A documentation update is advised, to describe environment variable usage to supply API keys.
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Adds support for using environment variables for API keys across multiple providers, updates UI components to reflect this, and enhances testing and translation capabilities.
anthropic,glama,openrouter,openai,gemini,mistral,deepseek,unbound,requesty,xai,groq,chutes,litellminprovider-settings.ts.validateModelsAndKeysProvided()invalidate.tsto check for environment variable usage for API keys.ApiKeycomponent inApiKey.tsxto handle API key input and environment variable toggle.Anthropic.tsx,Chutes.tsx,DeepSeek.tsx, etc., to use the newApiKeycomponent.index.spec.tsandApiKey.spec.tsx.--create-missingoption infind-missing-translations.jsfor generating placeholder translation keys.This description was created by
for f154eb2. You can customize this summary. It will automatically update as commits are pushed.