-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add search functionality to mode selector and reorganize layout #6129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add search input with clear button to filter modes - Move marketplace and settings buttons to bottom of popup - Replace instruction text with info icon tooltip - Update all localization files with new translation keys - Maintain consistent UI pattern with model selector Fixes #6128
@@ -116,7 +116,9 @@ | |||
"title": "Modos", | |||
"marketplace": "Marketplace de Modos", | |||
"settings": "Configuración de Modos", | |||
"description": "Personalidades especializadas que adaptan el comportamiento de Roo." | |||
"description": "Personalidades especializadas que adaptan el comportamiento de Roo.", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keys 'searchPlaceholder' and 'noMatchFound' in the modeSelector object still use English text. Please update these to proper Spanish translations.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "Buscar modos...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -116,7 +116,9 @@ | |||
"title": "Modes", | |||
"marketplace": "Marketplace de Modes", | |||
"settings": "Paramètres des Modes", | |||
"description": "Personas spécialisés qui adaptent le comportement de Roo." | |||
"description": "Personas spécialisés qui adaptent le comportement de Roo.", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keys 'searchPlaceholder' and 'noMatchFound' are still in English. Consider providing French translations for these keys.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "Rechercher des modes...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -122,7 +122,9 @@ | |||
"title": "Mode", | |||
"marketplace": "Marketplace Mode", | |||
"settings": "Pengaturan Mode", | |||
"description": "Persona khusus yang menyesuaikan perilaku Roo." | |||
"description": "Persona khusus yang menyesuaikan perilaku Roo.", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keys 'searchPlaceholder' and 'noMatchFound' in the modeSelector are still in English. Please update with proper Indonesian translations.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "Cari mode...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -116,7 +116,9 @@ | |||
"title": "Modalità", | |||
"marketplace": "Marketplace delle Modalità", | |||
"settings": "Impostazioni Modalità", | |||
"description": "Personalità specializzate che adattano il comportamento di Roo." | |||
"description": "Personalità specializzate che adattano il comportamento di Roo.", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keys for 'searchPlaceholder' and 'noMatchFound' are not translated into Italian. Please provide appropriate translations.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "Cerca modalità...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -116,7 +116,9 @@ | |||
"title": "モード", | |||
"marketplace": "モードマーケットプレイス", | |||
"settings": "モード設定", | |||
"description": "Rooの動作をカスタマイズする専門的なペルソナ。" | |||
"description": "Rooの動作をカスタマイズする専門的なペルソナ。", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added keys 'searchPlaceholder' and 'noMatchFound' in the modeSelector are in English. These should be localized into Japanese.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "モードを検索...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -108,7 +108,9 @@ | |||
"title": "Режимы", | |||
"marketplace": "Маркетплейс режимов", | |||
"settings": "Настройки режимов", | |||
"description": "Специализированные персоны, которые настраивают поведение Roo." | |||
"description": "Специализированные персоны, которые настраивают поведение Roo.", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keys in the modeSelector section ('searchPlaceholder' and 'noMatchFound') are still in English. Please provide the appropriate Russian translations.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "Поиск режимов...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -116,7 +116,9 @@ | |||
"title": "Modlar", | |||
"marketplace": "Mod Pazaryeri", | |||
"settings": "Mod Ayarları", | |||
"description": "Roo'nun davranışını özelleştiren uzmanlaşmış kişilikler." | |||
"description": "Roo'nun davranışını özelleştiren uzmanlaşmış kişilikler.", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keys 'searchPlaceholder' and 'noMatchFound' in the modeSelector object remain in English. Consider providing Turkish translations for these keys.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "Modları ara...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -116,7 +116,9 @@ | |||
"title": "Chế độ", | |||
"marketplace": "Chợ Chế độ", | |||
"settings": "Cài đặt Chế độ", | |||
"description": "Các nhân cách chuyên biệt điều chỉnh hành vi của Roo." | |||
"description": "Các nhân cách chuyên biệt điều chỉnh hành vi của Roo.", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modeSelector section's new keys ('searchPlaceholder' and 'noMatchFound') are in English. Please localize these into Vietnamese.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "Tìm kiếm chế độ...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -116,7 +116,9 @@ | |||
"title": "模式", | |||
"marketplace": "模式市场", | |||
"settings": "模式设置", | |||
"description": "专门定制Roo行为的角色。" | |||
"description": "专门定制Roo行为的角色。", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keys 'searchPlaceholder' and 'noMatchFound' under modeSelector are still in English. Please update them with proper Simplified Chinese translations.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "搜索模式...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
@@ -116,7 +116,9 @@ | |||
"title": "模式", | |||
"marketplace": "模式市集", | |||
"settings": "模式設定", | |||
"description": "專門定制Roo行為的角色。" | |||
"description": "專門定制Roo行為的角色。", | |||
"searchPlaceholder": "Search modes...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keys 'searchPlaceholder' and 'noMatchFound' are added in English within the modeSelector. Please provide Traditional Chinese translations for these keys.
"searchPlaceholder": "Search modes...", | |
"searchPlaceholder": "搜尋模式...", |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
This PR addresses issue #6128 by adding search functionality to the mode selector popup and reorganizing its layout to match the model selector design pattern.
Changes Made
1. Added Search Functionality
2. Reorganized Layout
3. Updated Localization
searchPlaceholder
andnoMatchFound
Technical Details
Screenshots
The mode selector now has:
This creates a consistent user experience between the mode selector and model selector popups.
Fixes #6128
Important
Adds search functionality to
ModeSelector.tsx
, reorganizes layout, and updates localization files for new features.ModeSelector.tsx
with a search input and clear button.searchPlaceholder
andnoMatchFound
keys to 17 localization files.This description was created by
for 0482256. You can customize this summary. It will automatically update as commits are pushed.