feat: Add SVN commit support with GUI interface #6101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
dosubot
bot
added
size:XL
hannesrudolph
added
the
Issue/PR - Triage
- Add SVN utility functions in src/utils/svn.ts mirroring git.ts functionality - Add SvnCommit type and svnCommitSearchResults to ExtensionMessage - Add searchSvnCommits message type to WebviewMessage - Update webviewMessageHandler to handle SVN commit searches - Update context-mentions to support SVN revision patterns (r123, @svn-changes) - Update ChatTextArea to trigger SVN searches and display results - Add comprehensive test suite for SVN functionality - Implement SVN repository info extraction and working state detection Fixes #6100
roomote
bot
force-pushed
the
feature/add-svn-support
branch
from
a873ff8 to
f891aef
Compare
4 tasks
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -201,6 +212,17 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>( | |||
| } | |||
| }, [selectedType, searchQuery]) | |||
|
|
|||
| // Fetch SVN commits when SVN is selected or when typing a revision number. | |||
| useEffect(() => { | |||
| if (selectedType === ContextMenuOptionType.Svn || /^r?\d+$/i.test(searchQuery)) { | |||
There was a problem hiding this comment.
The useEffect that triggers SVN commit searches (when selectedType is SVN or query matches a revision pattern) mirrors the Git search effect effectively. Consider adding a brief comment to clarify the regex logic used for SVN revisions for maintainability.
Suggested change
| if (selectedType === ContextMenuOptionType.Svn || /^r?\d+$/i.test(searchQuery)) { | |
| if (selectedType === ContextMenuOptionType.Svn || /^r?\d+$/i.test(searchQuery)) { // Matches SVN revision numbers like "123" or "r123" |
|
Implemented on #6117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements SVN (Subversion) commit support with a GUI interface similar to the existing Git commits functionality, as requested in #6100.
Changes
Testing
All tests pass successfully:
Fixes #6100
Important
This PR adds SVN commit support with a GUI interface, including new utility functions, message types, and context menu options, along with comprehensive tests.
svn.ts:checkSvnInstalled,searchSvnCommits,getSvnCommitInfo,getSvnWorkingState.ChatTextArea.tsxandwebviewMessageHandler.ts.context-mentions.ts.SvnCommittype andsvnCommitSearchResultsmessage type toExtensionMessage.tsandWebviewMessage.ts.searchSvnCommitsmessage inwebviewMessageHandler.ts.svn.test.ts.mentionRegexincontext-mentions.tsto include SVN patterns.ChatTextArea.tsxfor SVN commit handling.This description was created by
for f891aef. You can customize this summary. It will automatically update as commits are pushed.