fix: add null check for regex match to prevent "Cannot read properties of undefined" error

[roomote]

Fixes #6096

Summary

This PR fixes the "Cannot read properties of undefined (reading '0')" error that occurs during retry attempts when handling 429 rate limit errors with Gemini API retry details.

Changes

• Added proper null check for match[1] before accessing it in Task.ts line 1835
• The regex match can return null when the pattern doesn't match, which was causing the error

Testing

• Added comprehensive test coverage for the 429 retry logic with Gemini error details
• Tests cover three scenarios:
  1. Valid retry delay format (e.g., "10s")
  2. Invalid retry delay format (e.g., "invalid")
  3. Missing retry delay property

Technical Details

The issue occurred when the code tried to parse the retry delay from Gemini error details:

const match = geminiRetryDetails?.retryDelay?.match(/^(\d+)s$/)
if (match) {  // This check was insufficient
    exponentialDelay = Number(match[1]) + 1  // Error here when match is null
}

Now fixed to:

const match = geminiRetryDetails?.retryDelay?.match(/^(\d+)s$/)
if (match && match[1]) {  // Added null check for match[1]
    exponentialDelay = Number(match[1]) + 1
}

---

Important

Fixes a "Cannot read properties of undefined" error in Task.ts by adding a null check for regex matches, with tests for various retry scenarios.

• Behavior:
  • Fixes "Cannot read properties of undefined (reading '0')" error in Task.ts by adding a null check for match[1] in line 1835.
  • Handles cases where regex match returns null due to non-matching patterns.
• Testing:
  • Adds tests in Task.spec.ts for 429 retry logic with Gemini error details.
  • Tests cover valid, invalid, and missing retry delay formats.
• Technical Details:
  • Updates regex match logic in Task.ts to include a null check for match[1] to prevent errors when accessing undefined properties.

^{This description was created by for f23b27a. You can customize this summary. It will automatically update as commits are pushed.}

[daniel-lxs]

The author closed the issue as completed, see #6096 (comment)