-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: restore list styles for markdown lists in chat interface #6095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add list-style-type for ol (decimal) and ul (disc) elements - Add nested list styles for better visual hierarchy - Add comprehensive tests for list rendering - Fixes #6094
@roomote-agent can you write an e2e integration test (using integration test mode)? |
Hi @hannesrudolph! I see your request to write an e2e integration test for the markdown list styles fix. I'll get started on that right away using the integration test mode. 🚀 |
|
- Add tests for unordered lists with bullet points - Add tests for ordered lists with numbers - Add tests for nested list hierarchy - Add tests for mixed ordered/unordered lists - Verify proper rendering of list styles in chat interface
Hi @hannesrudolph! I've successfully added e2e integration tests for the markdown list rendering fix. What I added:
The tests verify that markdown lists are properly rendered in the chat interface with the correct list styles (bullets, numbers, and proper nesting). The changes have been pushed to the PR branch and CI checks are currently running. You can review the test file to see the implementation details. Let me know if you need any adjustments! 🎯 |
This PR fixes the issue where markdown lists (both ordered and unordered) were not displaying properly in the chat interface due to CSS reset rules.
Problem
The
preflight.css
file contains a CSS reset that removes all list styles:While the
MarkdownBlock
component applied padding and margins to lists, it did not restore thelist-style-type
property.Solution
list-style-type: decimal
for ordered lists (ol
)list-style-type: disc
for unordered lists (ul
)ul
elements use circle and square stylesol
elements use lower-alpha and lower-roman stylesTesting
Fixes #6094
Important
Fixes markdown list rendering in chat by restoring list styles in
MarkdownBlock.tsx
and adding tests.list-style-type
forol
andul
inMarkdownBlock.tsx
to display ordered and unordered lists correctly.ul ul
uses circle,ul ul ul
uses square,ol ol
uses lower-alpha,ol ol ol
uses lower-roman.markdown-lists.test.ts
with 4 test cases for unordered, ordered, nested, and mixed lists.MarkdownBlock.spec.tsx
with tests for unordered, ordered, and nested lists.preflight.css
.This description was created by
for 1e2cedf. You can customize this summary. It will automatically update as commits are pushed.