feat: add experimental setting to prevent editor focus disruption #6093
Conversation
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
- Add experimentalPreventFocusDisruption setting to package.json - Update DiffViewProvider to respect the new setting when opening diff views - Add localization entry for the new setting - Add comprehensive tests for the new functionality Fixes #4784
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
|
@roomote-agent experimental settings are not vscode settings, they are in the settings pane of the plugin. |
|
Thanks for the clarification @hannesrudolph! I understand now - experimental settings should be in the plugin's settings pane rather than VSCode settings. I'll update the implementation to move this setting to the proper location. Working on it now. |
- Remove experimentalPreventFocusDisruption from VSCode settings - Add PREVENT_FOCUS_DISRUPTION to experiments system - Update DiffViewProvider to use experiments instead of VSCode config - Update Task.ts to pass experiments to DiffViewProvider - Add localization entries for the new experiment - Update tests to use the experiments system This change moves the experimental setting from VSCode configuration to the plugin's experimental settings system as requested.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -198,7 +214,15 @@ export class DiffViewProvider { | |||
| await updatedDocument.save() | |||
| } | |||
|
|
|||
| await vscode.window.showTextDocument(vscode.Uri.file(absolutePath), { preview: false, preserveFocus: true }) | |||
| // Check if the experimental setting is enabled | |||
| const preventFocusDisruption = this.experiments | |||
There was a problem hiding this comment.
Good use of the experimental flag: using Experiments.isEnabled to set preserveFocus ensures that file edits won’t steal focus when the experiment is enabled. Consider extracting this flag lookup into a helper function if similar checks occur elsewhere to reduce duplication.
- Added placeholder translations for all locales - Uses English text as placeholder until proper translations are provided - Fixes failing translation check in CI
| @@ -618,6 +618,10 @@ | |||
| "MULTI_FILE_APPLY_DIFF": { | |||
| "name": "啟用並行檔案編輯", | |||
| "description": "啟用後 Roo 可在單個請求中編輯多個檔案。停用後 Roo 必須逐個編輯檔案。停用此功能有助於使用能力較弱的模型或需要更精確控制檔案修改時。" | |||
| }, | |||
| "PREVENT_FOCUS_DISRUPTION": { | |||
There was a problem hiding this comment.
The new 'PREVENT_FOCUS_DISRUPTION' entry still uses English text for both its name and description. For consistency with other localized entries, please provide proper Traditional Chinese translations.
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
|
Thanks for the feedback @hannesrudolph! I've successfully refactored the Changes made:
All CI checks are now passing. The setting will now appear in the plugin's experimental settings pane instead of VSCode's settings. |
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
This PR implements an experimental setting to prevent file edits from stealing focus, addressing the issue where diff views disrupt the user's workflow.
Summary
When Roo Code edits files, it opens diff views that steal focus from whatever the user is currently working on. This creates a frustrating experience that makes it nearly impossible to work alongside Roo. This PR adds an experimental setting
experimentalPreventFocusDisruptionthat, when enabled, prevents file edits from stealing focus.Changes
roo-cline.experimentalPreventFocusDisruption(default: false)DiffViewProviderto respect the new setting when:Testing
preserveFocusis correctly set based on the configuration valueUser Experience
When the setting is disabled (default):
When the setting is enabled:
Fixes #4784
Important
Adds an experimental setting
experimentalPreventFocusDisruptionto prevent focus changes during file edits, updatingDiffViewProviderand adding tests and localization support.experimentalPreventFocusDisruptionsetting to prevent focus change during file edits.DiffViewProviderto respect this setting when opening, saving, and reverting changes.roo-cline.experimentalPreventFocusDisruptionconfiguration property (default: false).preserveFocusbehavior based on the new setting inDiffViewProvider.spec.ts.This description was created by
for aacdc1d. You can customize this summary. It will automatically update as commits are pushed.