Fix Ollama API URL normalization by removing trailing slashes #6079
+90
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #6078
Roo Code Task Context (Optional)
Description
Ensures consistent behavior when constructing API endpoint URLs by normalizing the base URL to remove any trailing slashes. This prevents issues when the base URL is provided with trailing slashes.
Test Procedure
Added tests to verify URL normalization works correctly with:
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Does this PR necessitate updates to user-facing documentation?
Additional Notes
Get in Touch
Important
Normalize
ollamaBaseUrl
inCodeIndexOllamaEmbedder
to remove trailing slashes, ensuring consistent API endpoint construction.ollamaBaseUrl
inCodeIndexOllamaEmbedder
constructor to remove trailing slashes.ollama.spec.ts
for URLs with single, multiple, and no trailing slashes.This description was created by
for 2f6d6f9. You can customize this summary. It will automatically update as commits are pushed.