Skip to content

Use SIGKILL for command execution timeouts in the "execa" variant #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2025

Conversation

cte
Copy link
Collaborator

@cte cte commented Jul 22, 2025

Important

Change process termination signal to SIGKILL in ExecaTerminalProcess and adjust related configurations and logging.

  • Behavior:
    • Change signal from SIGINT to SIGKILL for terminating processes in ExecaTerminalProcess.
    • Enable --rm flag in Docker arguments in createRun() in runs.ts.
    • Adjust commandExecutionTimeout in EVALS_SETTINGS to 20ms in global-settings.ts.
  • Logging:
    • Add detailed logging for process termination in ExecaTerminalProcess.
    • Log subprocess start and termination in executeCommand() in executeCommandTool.ts.

This description was created by Ellipsis for d465e6c. You can customize this summary. It will automatically update as commits are pushed.

Copy link

delve-auditor bot commented Jul 22, 2025

No security or compliance issues detected. Reviewed everything up to 436a606.

Security Overview
  • 🔎 Scanned files: 5 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► runs.ts
    Update docker arguments configuration
► runTask.ts
    Add loggable says configuration
► global-settings.ts
    Update evals settings defaults
► executeCommandTool.ts
    Refine command execution handling
► ExecaTerminalProcess.ts
    Enhance process termination logic
Refactor ► ChatRow.tsx
    Remove file jump functionality
► CodeAccordian.tsx
    Remove file jump functionality

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 22, 2025
@cte cte marked this pull request as ready for review July 22, 2025 18:09
@cte cte requested review from mrubens and jr as code owners July 22, 2025 18:09
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 22, 2025
@cte cte merged commit 9956cc1 into main Jul 23, 2025
10 checks passed
@cte cte deleted the cte/command-execution-timeout-fixes branch July 23, 2025 08:47
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 23, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants