fix: persist edit warning dialog preference during session #6057
+28
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KJ7LNW
force-pushed
the
fix-edit-warning-dialog-persistence
branch
from
0030fd5 to
0408cc1
Compare
This change fixes the issue where the edit warning dialog appears on every edit, even after the user has already seen it once. The solution: 1. Uses a React ref to store the preference in memory during the session 2. Bypasses the dialog if the user has already seen it 3. Adds double-click functionality to user messages for quick editing The preference is reset when the VS Code window is reloaded, ensuring users are reminded of the warning after a restart. Fixes: #6058 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
KJ7LNW
force-pushed
the
fix-edit-warning-dialog-persistence
branch
from
0408cc1 to
52031a5
Compare
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When editing a message, the user is shown a warning dialog. Currently, this dialog appears every time a message is edited, even if the user has already seen it in the current session. This creates a frustrating user experience when editing multiple messages.
Implementation
This change fixes the issue by:
hasSeenEditWarningRef) to store the preference in memory during the sessionThe preference is reset when the VS Code window is reloaded, ensuring users are reminded of the warning after a restart.
How to Test
Fixes #6058
Get in Touch
Discord: KJ7LNW