feat: add efficiency warnings for single SEARCH/REPLACE blocks in apply_diff #6056
+255
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #6054 by adding efficiency warnings to the apply_diff tool when only one SEARCH/REPLACE block is used, similar to how the read_file tool warns when only one file is read.
Changes Made
Updated tool descriptions in diff strategies:
multi-search-replace.ts
getToolDescriptionmulti-file-search-replace.ts
getToolDescriptionCreated dynamic warning functions:
getApplyDiffDescription
inapplyDiffTool.ts
for legacy formatgetApplyDiffDescription
inmultiApplyDiffTool.ts
for multi-file formatUpdated assistant message presentation:
presentAssistantMessage.ts
to use the new description functionsAdded comprehensive tests:
getApplyDiffDescription.spec.ts
with tests for both legacy and multi-file formatsBenefits
Testing
All tests pass:
Fixes #6054
Important
Adds efficiency warnings for single SEARCH/REPLACE blocks in
apply_diff
tool, encouraging batching of changes for improved efficiency.apply_diff
tool, similar toread_file
tool.getToolDescription
inmulti-search-replace.ts
andmulti-file-search-replace.ts
to include warnings.getApplyDiffDescription
inapplyDiffTool.ts
andmultiApplyDiffTool.ts
to dynamically generate warnings.presentAssistantMessage.ts
to use new description functions for displaying warnings.getApplyDiffDescription.spec.ts
with tests for single and multiple SEARCH/REPLACE blocks.apply_diff
call.read_file
tool behavior.This description was created by
for 4fcdea1. You can customize this summary. It will automatically update as commits are pushed.