-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add support for Agent Rules standard via AGENTS.md (#5966) #5969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add AGENTS.md detection and loading in custom-instructions.ts - Add VS Code setting "roo-cline.useAgentRules" (default: true) - Integrate with existing custom instructions system - Add comprehensive test coverage for AGENTS.md functionality - Update README to mention Agent Rules support This enables unified natural language guidelines across different AI coding tools following the agent-rules.org standard.
- Revert README.md changes (no longer needed) - Add agent-rules.org link to useAgentRules setting description - Change default value of useAgentRules to false - Update tests to reflect new default behavior - Update all language translations with the new setting description
2c7a4a7
to
d149c5b
Compare
As requested in PR review, removing the Agent Rules mention from README.md since the feature is now disabled by default.
@@ -297,6 +318,14 @@ export async function addCustomInstructions( | |||
rules.push(options.rooIgnoreInstructions) | |||
} | |||
|
|||
// Add AGENTS.md content if enabled (default: false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition for including AGENTS.md has been changed from options.useAgentRules !== false
to options.useAgentRules === true
, and the comment now says "default: false". This conflicts with the PR description which states the default should be true. Please clarify and align the default behavior (and documentation) for useAgentRules.
@roomote-agent can you add AGENTS.md to the list of protected files? |
Hi @mrubens! I see your request to add AGENTS.md to the list of protected files. I'll work on this right away. |
Hi @mrubens! I've successfully added AGENTS.md to the list of protected files. Here's what I did:
All tests are passing and CI checks have completed successfully. The AGENTS.md file will now be write-protected and require approval for modifications, just like other Roo configuration files. |
@roomote-agent i think we should default this setting to true |
Hi @mrubens! Great question about the design choice. The AGENTS.md file approach was chosen over passing rules through settings for several key reasons:
The VS Code setting ( This approach aligns with the issue #5966 goals of reducing fragmentation and enabling teams to maintain consistent guidelines across different AI tools. |
Hi @mrubens! I see your comment about defaulting the |
- Updated default value in package.json from false to true - Updated implementation to load AGENTS.md when useAgentRules is undefined - Updated test expectations to match new default behavior - Updated fallback values in Task.ts and generateSystemPrompt.ts This enables AGENTS.md loading by default as requested by @mrubens
✅ Done! I've updated the default value of Changes made:
All CI checks are now passing! The Agent Rules standard (AGENTS.md) will now be loaded by default when the setting is not explicitly configured. |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Implements #5966 - Adds support for the Agent Rules standard (agent-rules.org) via project root AGENTS.md files. This enables unified natural language guidelines across different AI coding tools.
Changes
roo-cline.useAgentRules
(default: true) to enable/disable the featureImplementation Details
Testing
This implementation follows the approach outlined in the issue description, making AGENTS.md optional and complementary to existing YAML modes.
Important
Adds support for
AGENTS.md
files in the prompt system, with a new setting to enable/disable its use, and updates tests and documentation accordingly.AGENTS.md
incustom-instructions.ts
, integrating content into the prompt system.roo-cline.useAgentRules
setting inpackage.json
to enable/disableAGENTS.md
loading (default: true).RooProtectedController
to protectAGENTS.md
files.AGENTS.md
from project root, included in prompt rules section.AGENTS.md
if not present.custom-instructions.spec.ts
forAGENTS.md
loading and error handling.system-prompt.spec.ts
to testuseAgentRules
setting.README.md
and localization files to mentionAGENTS.md
support.This description was created by
for d3fb2b4. You can customize this summary. It will automatically update as commits are pushed.