fix(ci): correct shell usage and artifact path in release workflow

This commit addresses two issues in the release workflow (`release.yml`):

1.  **Remove invalid `shell:` key usage:** The "Package release artifacts" step incorrectly tried to use `${{ matrix.archive_shell }}` for the `shell:` key. This key requires a predefined shell keyword, not a runtime expression. The step now relies on the runner's default shell (bash/pwsh), which matches the required shells for the archive commands.

2.  **Fix artifact upload path:** The `ARCHIVE_NAME` variable, set dynamically via `$GITHUB_ENV`, was not accessible using `${{ env.ARCHIVE_NAME }}` in the `actions/upload-artifact` step's `path` input. The "Prepare archive name" step now also sets a step output (`archive_filename`), and the upload step uses this output (`${{ steps.prepare_archive_name.outputs.archive_filename }}`) to correctly specify the artifact path.

Author: Romelium

.github/workflows/release.yml

@@ -71,7 +71,14 @@ jobs:
         run: cargo build --release --target ${{ matrix.target }} --verbose
 
       - name: Prepare archive name
-        run: echo "ARCHIVE_NAME=${{ env.BINARY_NAME }}-${{ github.ref_name }}-${{ matrix.target }}.${{ matrix.archive_format }}" >> $GITHUB_ENV
+        id: prepare_archive_name # Add an ID to the step
+        run: |
+          # Calculate the filename
+          archive_filename="${{ env.BINARY_NAME }}-${{ github.ref_name }}-${{ matrix.target }}.${{ matrix.archive_format }}"
+          # Set environment variable for subsequent run steps (like packaging)
+          echo "ARCHIVE_NAME=${archive_filename}" >> $GITHUB_ENV
+          # Set step output for use in action inputs (like upload-artifact path)
+          echo "::set-output name=archive_filename::${archive_filename}"
         shell: bash
 
       - name: Create staging directory
@@ -98,13 +105,14 @@ jobs:
 
       - name: Package release artifacts from staging directory
         run: ${{ matrix.archive_command }}
-        shell: ${{ matrix.archive_shell }}
+        # No shell: key needed
 
       - name: Upload release asset
         uses: actions/upload-artifact@v4
         with:
           name: release-assets
-          path: ${{ env.ARCHIVE_NAME }}
+          # Use the output from the 'prepare_archive_name' step
+          path: ${{ steps.prepare_archive_name.outputs.archive_filename }}
 
   create-release:
     name: Create GitHub Release