fix(ci): resolve artifact conflicts and deprecation warnings in release workflow

This commit addresses two issues in the release workflow (`release.yml`):

1.  **Artifact Upload Conflict (409):** The `build-release` jobs were failing with a 409 Conflict error because they all tried to upload an artifact with the same name (`release-assets`). This is resolved by giving each uploaded artifact a unique name based on the build target (`release-asset-${{ matrix.target }}`). The `create-release` job is updated to download all artifacts from the run, ensuring all binaries are collected before creating the GitHub Release.

2.  **`set-output` Deprecation:** The workflow used the deprecated `::set-output` command to set the `archive_filename` step output. This has been updated to use the recommended method of writing to the `$GITHUB_OUTPUT` environment file, resolving the deprecation warnings.

Author: Romelium

.github/workflows/release.yml

@@ -27,7 +27,7 @@ jobs:
             archive_format: tar.gz
             archive_command: |
               tar czf "$ARCHIVE_NAME" -C "$STAGING_DIR" .
-            archive_shell: bash
+            archive_shell: bash # Keep for reference, but not used in shell: key
 
           # macOS (Intel x86_64) - tar.gz archive
           - os: macos-latest
@@ -36,7 +36,7 @@ jobs:
             archive_format: tar.gz
             archive_command: |
               tar czf "$ARCHIVE_NAME" -C "$STAGING_DIR" .
-            archive_shell: bash
+            archive_shell: bash # Keep for reference, but not used in shell: key
 
           # macOS (Apple Silicon arm64) - tar.gz archive
           - os: macos-14
@@ -45,7 +45,7 @@ jobs:
             archive_format: tar.gz
             archive_command: |
               tar czf "$ARCHIVE_NAME" -C "$STAGING_DIR" .
-            archive_shell: bash
+            archive_shell: bash # Keep for reference, but not used in shell: key
 
           # Windows (MSVC x86_64) - zip archive
           - os: windows-latest
@@ -54,7 +54,7 @@ jobs:
             archive_format: zip
             archive_command: |
               Compress-Archive -Path "$($env:STAGING_DIR)\*" -DestinationPath "$env:ARCHIVE_NAME"
-            archive_shell: pwsh
+            archive_shell: pwsh # Keep for reference, but not used in shell: key
 
     steps:
       - name: Checkout repository
@@ -71,14 +71,14 @@ jobs:
         run: cargo build --release --target ${{ matrix.target }} --verbose
 
       - name: Prepare archive name
-        id: prepare_archive_name # Add an ID to the step
+        id: prepare_archive_name # Step ID remains
         run: |
           # Calculate the filename
           archive_filename="${{ env.BINARY_NAME }}-${{ github.ref_name }}-${{ matrix.target }}.${{ matrix.archive_format }}"
           # Set environment variable for subsequent run steps (like packaging)
           echo "ARCHIVE_NAME=${archive_filename}" >> $GITHUB_ENV
-          # Set step output for use in action inputs (like upload-artifact path)
-          echo "::set-output name=archive_filename::${archive_filename}"
+          # Set step output using the new method for use in action inputs
+          echo "archive_filename=${archive_filename}" >> $GITHUB_OUTPUT
         shell: bash
 
       - name: Create staging directory
@@ -105,12 +105,13 @@ jobs:
 
       - name: Package release artifacts from staging directory
         run: ${{ matrix.archive_command }}
-        # No shell: key needed
+        # No shell: key needed here
 
       - name: Upload release asset
         uses: actions/upload-artifact@v4
         with:
-          name: release-assets
+          # Use a unique name for each artifact based on the target
+          name: release-asset-${{ matrix.target }}
           # Use the output from the 'prepare_archive_name' step
           path: ${{ steps.prepare_archive_name.outputs.archive_filename }}
 
@@ -123,8 +124,8 @@ jobs:
       - name: Download all release assets
         uses: actions/download-artifact@v4
         with:
-          name: release-assets
-          path: release-assets
+          # No 'name' specified, download all artifacts from the run
+          path: release-assets # All downloaded artifacts will land here
 
       - name: List downloaded files (for debugging)
         run: ls -R release-assets
@@ -135,6 +136,7 @@ jobs:
           tag_name: ${{ github.ref_name }}
           name: Release ${{ github.ref_name }}
           generate_release_notes: true
+          # This glob will now find all the archive files downloaded into release-assets
           files: release-assets/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}