Skip to content

Commit 2c2f3b3

Browse files
committed
fix(ci): correct glob pattern for finding downloaded release assets
The `create-release` job was failing to attach assets to the GitHub Release because the `files` glob pattern was incorrect. When `actions/download-artifact@v4` downloads multiple artifacts without a specific name (as used in this job), it places each artifact's contents into a subdirectory named after the artifact within the specified `path` (e.g., `release-assets/release-asset-x86_64-unknown-linux-gnu/`). The previous glob pattern `release-assets/*` matched these subdirectories, but the `softprops/action-gh-release` action requires paths to the actual files to be uploaded. This commit changes the glob pattern to `release-assets/*/*`, which correctly finds the archive files (`.tar.gz`, `.zip`) located *inside* the subdirectories created by the download step, allowing them to be successfully attached to the release.
1 parent 5656b38 commit 2c2f3b3

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ jobs:
136136
tag_name: ${{ github.ref_name }}
137137
name: Release ${{ github.ref_name }}
138138
generate_release_notes: true
139-
# This glob will now find all the archive files downloaded into release-assets
140-
files: release-assets/*
139+
files: release-assets/*/*
141140
env:
142141
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)