Skip to content

Add a new mod [Calendar and Weather] #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 13, 2025
Merged

Add a new mod [Calendar and Weather] #2073

merged 12 commits into from
Jun 13, 2025

Conversation

mailare49
Copy link
Contributor

Add a new mod in Roll20 API scripts.
This mod is an entire customizable calendar and weather in english and french.

@kfroll20
Copy link
Contributor

Hello @mailare49!

Thank you for contributing to the API scripts repo. Everything looks good to publish, but we will need a subfolder for your version as outlined in the documentation.

As this is the first version, you can go ahead and make a subfolder named 1.0 with the Calender and Weather.js file in it :)

Thanks!

@mailare49
Copy link
Contributor Author

Hello @kfroll20, thanks for fast answer. I have create the subfolder to put the mod inside.

@kfroll20 kfroll20 self-requested a review June 12, 2025 18:26
Copy link
Contributor

@kfroll20 kfroll20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON validator is failing because dependencies in your script.json file is an empty string when it needs to be a list

"dependencies": []

@mailare49
Copy link
Contributor Author

Hello, I have correct this.

@kfroll20
Copy link
Contributor

Perfect, thank you! Just so you're aware, there are a great number of websites down due to a google outage so I am holding off on doing any merges until it has been resolved. Otherwise this looks good to go so I will merge once we have been given the greenlight!

@mailare49
Copy link
Contributor Author

Thanks for informations

@kfroll20 kfroll20 merged commit 820e59d into Roll20:master Jun 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants