Skip to content

GroupCheck dark theme option #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

Dambroda
Copy link
Contributor

I'm a roll20 dark mode user, and the group check output was starting to get hard/jarring for me to read because it assumes you're in light mode:

image

I decided to copy GroupCheck as a custom script for my game so I could make some half-assed theme changes for myself to make the output legible... and then figured I may as well spend the extra hour to make my changes a persistent setting and see if anyone else wants to use them.

  • Stays light mode by default, which should retain the same theme as if there were no changes.
  • Toggled via !group-check-config --set [darkmode/lightmode]
  • Only changes very specific styles, so this should only really be set if your roll20 is already in darkmode; it still inherits things like general font styles from the base roll20 UI. (Setting the script to darkmode while your roll20 is in lightmode would be almost entirely illegible). It probably wouldn't be too much work to be more thorough in what it styles...

I understand this is a very core script and this might not meet the standards for an update to it, and I wont be at all offended if this gets rejected :)

image

I have no idea what the API_META.offset stuff does at the top and bottom of the script file, so if that needs to be updated let me know

@Alicekb Alicekb merged commit f2c3604 into Roll20:master Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants