RPGM AttackMaster: Rogue table & Mods for Thac0, Dmg & HP #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DameryDad
commented
Jan 31, 2025
DameryDad
commented
- Expanded scanForArmour() to also scan for Thac0 and HP mods, and changed its name to scanForModifiers().
- Added tokenID to Mods table - if blank apply mod to character, else only apply mod to token.
- Added updateHitDmgBonus() to convert character sheets to use new mods table as and when GM desires.
- Code tidying and some utility functions moved to library.
- Improved error handling and type conversion.
- Made scanForModifiers() asynchronous.
- New dialog for displaying what effects and mods impact thac0, dmg, ac & hp.
- Added functions to auto-populate, display, and explain current rogue skill values.
- Correct item speed assessment to use inheritance via resolveData().
- Added doSetMod() function and commands to support new extended modifiers functionality.
* Expanded scanForArmour() to also scan for Thac0 and HP mods, and changed its name to scanForModifiers(). * Added tokenID to Mods table - if blank apply mod to character, else only apply mod to token. * Added updateHitDmgBonus() to convert character sheets to use new mods table as and when GM desires. * Code tidying and some utility functions moved to library. * Improved error handling and type conversion. * Made scanForModifiers() asynchronous. * New dialog for displaying what effects and mods impact thac0, dmg, ac & hp. * Added functions to auto-populate, display, and explain current rogue skill values. * Correct item speed assessment to use inheritance via resolveData(). * Added doSetMod() function and commands to support new extended modifiers functionality.
Alicekb
reviewed
Feb 4, 2025
AttackMaster/script.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "$schema": "https://github.com/DameryDad/roll20-api-scripts/blob/AttackMaster/AttackMaster/Script.json", | |||
| "name": "AttackMaster", | |||
| "script": "attackMaster.js", | |||
| "version": "3.5.0", | |||
| "version": "4.0.1", | |||
| "previousversions": ["1.036","1.038","1.039","1.041","1.042","2.046","1.3.00","1.3.01","1.3.02","1.3.03","1.4.01","1.4.02","1.4.03","1.4.04","1.4.05","1.4.06","1.4.07","1.5.01","1.5.02","1.5.03","2.1.0","2.2.0","2.3.0","2.3.1","2.3.2","2.3.3","3.0.0","3.1.2","3.2.0","3.2.1","3.3.0","3.4.0"], | |||
There was a problem hiding this comment.
It looks like you're missing the previous version in previousVersions section? or are you intentionally wanting to not include it?
There was a problem hiding this comment.
It should be included. My mistake. I've pushed the corrected script.json version. Please can you release as a matter of urgency as it goes with the rest of the RPGMaster suite v4 release. Thanks
Error in script.json excluded previous version from history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.