Skip to content

Update autobuttons to 0.9.0 #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

ooshhub
Copy link
Contributor

@ooshhub ooshhub commented Jan 26, 2025

  • Updated to 0.9.0
  • Removed all old, incompatible versions
  • Added dnd2024 beacon sheet support
  • Fixed styles, added --baseSize setting to scale elements
  • Added --beacon flag to enable beacon support

@Alicekb
Copy link
Contributor

Alicekb commented Jan 28, 2025

Hey @ooshhub, we generally don't allow the removal of old script versions. This causes issues with games that are running those removed versions of the script.

Could you update your pr to not delete those files and perhaps update the Readme with warnings about using those older versions.

@ooshhub
Copy link
Contributor Author

ooshhub commented Jan 29, 2025 via email

"modifies": {
"state.autoButtons": "read,write"
},
"conflicts": [],
"previousversions": ["0.5.4", "0.6.2", "0.7.2"]
"previousversions": ["0.8.9"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this suppose to be 0.8.0? I don't see a 0.8.9 in this folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hmmm... my diff is showing a 0.8.9 added and 0.8.0 removed. I'm definitely a few coffees short of full consciousness though, have I missed something?

@Alicekb
Copy link
Contributor

Alicekb commented Jan 30, 2025

In that case, there should be no harm in removing those versions, if you can clarity/correct the above, I'll get your script deploy as soon as possible

@Alicekb Alicekb merged commit 0ff7200 into Roll20:master Feb 4, 2025
1 check passed
@ooshhub ooshhub deleted the update-autobuttons-to-0.9.0 branch March 16, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants