-
Notifications
You must be signed in to change notification settings - Fork 579
Update autobuttons to 0.9.0 #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ooshhub
commented
Jan 26, 2025
- Updated to 0.9.0
- Removed all old, incompatible versions
- Added dnd2024 beacon sheet support
- Fixed styles, added --baseSize setting to scale elements
- Added --beacon flag to enable beacon support
- Updated to 0.9.0 - Added dependency
Hey @ooshhub, we generally don't allow the removal of old script versions. This causes issues with games that are running those removed versions of the script. Could you update your pr to not delete those files and perhaps update the Readme with warnings about using those older versions. |
Hi Alice,
I totally understand generally not allowing the removal of scripts, however
these old versions will all immediately crash the sandbox, specifically
because of this line:
static isObj(input) { return (typeof(input) === 'object' &&
*input.constructor.name
<http://input.constructor.name> *=== 'Object') ? true : false }
A quick bit of history for explanation:
A sandbox security update removed access to Object's prototype constructor
a while back which causes this to tank the sandbox.
Importantly, this includes the current version in the one-click - i.e.
there is *no version at all in the one-click that won't immediately lead to
a broken sandbox*
Although there is a working version in the autobuttons forum thread, it
never made it to one-click. Aaron pinged me around this time (I'd stopped
using the VTT by then) saying he'd fixed the script... I assumed he meant
he'd PR'd the new working version for me, but never actually checked. Turns
out he just fixed a version number mismatch... I really should have checked
😅
I only noticed the one-click version has been broken this whole time when a
couple of mods sent me a note asking if I felt like updating the script for
DnD 2024.
With all that said - I'm happy to update the PR and restore those versions
if that's what you'd prefer, but they'll immediately crash the sandbox if
installed. No active, working game could possibly have a version of this
enabled. But if removing these versions will break a campaign that has a
*disabled* old version installed (break it even more than having a
non-functional API sandbox) I can definitely see the point for leaving them
alone.
Let me know which option is less likely to lead to a busted campaign.
Thanks!
…On Wed, Jan 29, 2025 at 5:38 AM Alice ***@***.***> wrote:
Hey @ooshhub <https://github.com/ooshhub>, we generally don't allow the
removal of old script versions. This causes issues with games that are
running those removed versions of the script.
Could you update your pr to not delete those files and perhaps update the
Readme with warnings about using those older versions.
—
Reply to this email directly, view it on GitHub
<#2010 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARZUCTCAYKAASNVV2THAIOT2M7IRTAVCNFSM6AAAAABV4FV7ECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJZHA2DGNRTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
"modifies": { | ||
"state.autoButtons": "read,write" | ||
}, | ||
"conflicts": [], | ||
"previousversions": ["0.5.4", "0.6.2", "0.7.2"] | ||
"previousversions": ["0.8.9"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this suppose to be 0.8.0
? I don't see a 0.8.9
in this folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, there should be no harm in removing those versions, if you can clarity/correct the above, I'll get your script deploy as soon as possible |