Skip to content

Commit d7578d9

Browse files
fixes controllers create logs fault tolerancy
1 parent ada3010 commit d7578d9

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

lib/controllers/environment.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,10 @@ async def create_env(env: Env) -> Union[EnvCreated, HTTPException]:
5656
else:
5757
return EnvCreated(env_id=env_repo.env_id)
5858
finally:
59-
logger.info(
60-
f"Call to controllers.environment.create_env completed for Env {None or env_repo.env_id}"
61-
)
59+
if env_repo:
60+
logger.info(
61+
f"Call to controllers.environment.create_env completed for Env {env_repo.env_id}"
62+
)
6263

6364
@staticmethod
6465
async def get_env_by_id(env_id: str) -> Union[Env, HTTPException]:

lib/controllers/flight.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,10 @@ async def create_flight(
7373
else:
7474
return FlightCreated(flight_id=flight_repo.flight_id)
7575
finally:
76-
logger.info(
77-
f"Call to controllers.flight.create_flight completed for Flight {None or flight_repo.flight_id}"
78-
)
76+
if flight_repo:
77+
logger.info(
78+
f"Call to controllers.flight.create_flight completed for Flight {flight_repo.flight_id}"
79+
)
7980

8081
@staticmethod
8182
async def get_flight_by_id(

lib/controllers/motor.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,10 @@ async def create_motor(
6969
else:
7070
return MotorCreated(motor_id=motor_repo.motor_id)
7171
finally:
72-
logger.info(
73-
f"Call to controllers.motor.create_motor completed for Motor {None or motor_repo.motor_id}"
74-
)
72+
if motor_repo:
73+
logger.info(
74+
f"Call to controllers.motor.create_motor completed for Motor {motor_repo.motor_id}"
75+
)
7576

7677
@staticmethod
7778
async def get_motor_by_id(

lib/controllers/rocket.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,10 @@ async def create_rocket(
6363
else:
6464
return RocketCreated(rocket_id=rocket_repo.rocket_id)
6565
finally:
66-
logger.info(
67-
f"Call to controllers.rocket.create_rocket completed for Rocket {None or rocket_repo.rocket_id}"
68-
)
66+
if rocket_repo:
67+
logger.info(
68+
f"Call to controllers.rocket.create_rocket completed for Rocket {rocket_repo.rocket_id}"
69+
)
6970

7071
@staticmethod
7172
async def get_rocket_by_id(

0 commit comments

Comments
 (0)