Skip to content

Commit ada3010

Browse files
adds fault tolerancy for controllers creation logs
1 parent 55a445a commit ada3010

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

lib/controllers/environment.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ async def create_env(env: Env) -> Union[EnvCreated, HTTPException]:
3232
Returns:
3333
views.EnvCreated
3434
"""
35+
env_repo = None
3536
try:
3637
async with EnvRepository(env) as env_repo:
3738
await env_repo.create_env()
@@ -56,7 +57,7 @@ async def create_env(env: Env) -> Union[EnvCreated, HTTPException]:
5657
return EnvCreated(env_id=env_repo.env_id)
5758
finally:
5859
logger.info(
59-
f"Call to controllers.environment.create_env completed for Env {env_repo.env_id}"
60+
f"Call to controllers.environment.create_env completed for Env {None or env_repo.env_id}"
6061
)
6162

6263
@staticmethod

lib/controllers/flight.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ async def create_flight(
5050
Returns:
5151
views.FlightCreated
5252
"""
53+
flight_repo = None
5354
try:
5455
cls.guard(flight)
5556
async with FlightRepository(flight) as flight_repo:
@@ -73,7 +74,7 @@ async def create_flight(
7374
return FlightCreated(flight_id=flight_repo.flight_id)
7475
finally:
7576
logger.info(
76-
f"Call to controllers.flight.create_flight completed for Flight {flight_repo.flight_id}"
77+
f"Call to controllers.flight.create_flight completed for Flight {None or flight_repo.flight_id}"
7778
)
7879

7980
@staticmethod

lib/controllers/motor.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ async def create_motor(
4646
Returns:
4747
views.MotorCreated
4848
"""
49+
motor_repo = None
4950
try:
5051
cls.guard(motor)
5152
async with MotorRepository(motor) as motor_repo:
@@ -69,7 +70,7 @@ async def create_motor(
6970
return MotorCreated(motor_id=motor_repo.motor_id)
7071
finally:
7172
logger.info(
72-
f"Call to controllers.motor.create_motor completed for Motor {motor_repo.motor_id}"
73+
f"Call to controllers.motor.create_motor completed for Motor {None or motor_repo.motor_id}"
7374
)
7475

7576
@staticmethod

lib/controllers/rocket.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ async def create_rocket(
4040
Returns:
4141
views.RocketCreated
4242
"""
43+
rocket_repo = None
4344
try:
4445
cls.guard(rocket)
4546
async with RocketRepository(rocket) as rocket_repo:
@@ -63,7 +64,7 @@ async def create_rocket(
6364
return RocketCreated(rocket_id=rocket_repo.rocket_id)
6465
finally:
6566
logger.info(
66-
f"Call to controllers.rocket.create_rocket completed for Rocket {rocket_repo.rocket_id}"
67+
f"Call to controllers.rocket.create_rocket completed for Rocket {None or rocket_repo.rocket_id}"
6768
)
6869

6970
@staticmethod

0 commit comments

Comments
 (0)