Update to Rust 1.86 toolchain, 2024 Edition #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
giladwolff
changed the title
kushudai
reviewed
May 14, 2025
Cargo.toml
Outdated
| @@ -1,9 +1,9 @@ | |||
| [package] | |||
| name = "rs-consul" | |||
| # Don't forget to update the readme with the new version! | |||
| version = "0.10.0" | |||
| version = "0.10.1" | |||
There was a problem hiding this comment.
This is a breaking change. We need to release 0.11
People on older toolchains cannot use this crate anymore since their rustc will not recognize edition 2024.
There was a problem hiding this comment.
I would say we hold off until 1.87 which is only a couple of days away?
There was a problem hiding this comment.
Maybe I should hold off with updating the edition?
Actually, since I'm upgrading the toolchain to 1.86 this is not an additional requirement. I'll leave it in.
There was a problem hiding this comment.
Yeah, that would be fine too
kushudai
approved these changes
May 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
We are building on old rust toolchain.
How are we solving the problem?
Upgrade the toolchain. While doing this I update the Rust edition as well.
Checks
Please check these off before promoting the pull request to non-draft status.