Skip to content

Release build for linux arm64 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 5, 2025
Merged

Release build for linux arm64 #100

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a9d4655
Release build for linux arm64
Nicell May 5, 2025
144d426
22.04, snapshots, bump version
Nicell May 5, 2025
21cb902
do 22.04 here too
Nicell May 5, 2025
5451c87
oops
Nicell May 5, 2025
a1b66ca
undo that
Nicell May 5, 2025
438818f
update help command
Nicell May 5, 2025
00b6a2d
pin ubuntu to 22.04
Nicell May 5, 2025
9596054
temporarily test building ubuntu 22.04
Nicell May 5, 2025
5479fdf
artifact v4
Nicell May 5, 2025
fc8f347
build with arm ubuntu
Nicell May 5, 2025
a6e7c55
temp test worked
Nicell May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 38 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ jobs:
name: foreman-macos-arm64
path: target/aarch64-apple-darwin/release/foreman

linux:
runs-on: ubuntu-latest
linux-x86_64:
runs-on: ubuntu-22.04
Copy link
Member Author

@Nicell Nicell May 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switching to 22.04 to avoid glibc issues with 24.04 builds

timeout-minutes: 15

steps:
Expand All @@ -92,13 +92,32 @@ jobs:
- name: Upload artifacts
uses: actions/upload-artifact@v1
with:
name: foreman-linux
name: foreman-linux-x86_64
path: target/release/foreman

linux-arm64:
runs-on: ubuntu-22.04
timeout-minutes: 15

steps:
- uses: actions/checkout@v1

- name: Install Rust target for arm64
run: rustup target add aarch64-unknown-linux-gnu

- name: Build arm64 release binary
run: cargo build --locked --verbose --release --target aarch64-unknown-linux-gnu

- name: Upload arm64 artifacts
uses: actions/upload-artifact@v1
with:
name: foreman-linux-arm64
path: target/aarch64-unknown-linux-gnu/release/foreman

release:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
timeout-minutes: 15
needs: ["windows", "macos-x86-64", "macos-arm64", "linux"]
needs: ["windows", "macos-x86-64", "macos-arm64", "linux-x86_64", "linux-arm64"]
steps:
- uses: actions/checkout@v1
- name: Download artifacts
Expand All @@ -109,7 +128,8 @@ jobs:
zip -rj foreman-win64.zip ./artifacts/foreman-win64/*
zip -rj foreman-macos-x86_64.zip ./artifacts/foreman-macos-x86_64/*
zip -rj foreman-macos-arm64.zip ./artifacts/foreman-macos-arm64/*
zip -rj foreman-linux.zip ./artifacts/foreman-linux/*
zip -rj foreman-linux-x86_64.zip ./artifacts/foreman-linux-x86_64/*
zip -rj foreman-linux-arm64.zip ./artifacts/foreman-linux-arm64/*
- name: Create release
id: create_release
uses: actions/create-release@v1
Expand Down Expand Up @@ -156,6 +176,16 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ./foreman-linux.zip
asset_name: foreman-linux.zip
asset_path: ./foreman-linux-x86_64.zip
asset_name: foreman-linux-x86_64.zip
asset_content_type: application/zip

- name: Upload linux build (arm64)
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ./foreman-linux-arm64.zip
asset_name: foreman-linux-arm64.zip
asset_content_type: application/zip
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ default-members = [".", "artiaa_auth"]
[package]
name = "foreman"
description = "Toolchain manager for simple binary tools"
version = "1.6.3"
version = "1.6.4"
authors = [
"Lucien Greathouse <me@lpghatguy.com>",
"Matt Hargett <plaztiksyke@gmail.com>",
Expand Down
6 changes: 3 additions & 3 deletions tests/snapshots/install_all_tools_before_failing.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@ expression: content
Request from `https://api.github.com/repos/Roblox/NotARepository/releases`

Received body:
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/releases/releases#list-releases"}
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/releases/releases#list-releases","status":"404"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github apparently adds a status now

[INFO ] Downloading github.com/Roblox/@^0.2.0
[ERROR] The following error occurred while trying to download tool "badly-formatted-tool":
unexpected response body: invalid type: map, expected a sequence at line 1 column 0
Request from `https://api.github.com/repos/Roblox//releases`

Received body:
{"message":"Not Found","documentation_url":"https://docs.github.com/rest"}
{"message":"Not Found","documentation_url":"https://docs.github.com/rest","status":"404"}
[INFO ] Downloading github.com/Roblox/VeryFakeRepository@^0.1.0
[ERROR] The following error occurred while trying to download tool "not-a-real-tool":
unexpected response body: invalid type: map, expected a sequence at line 1 column 0
Request from `https://api.github.com/repos/Roblox/VeryFakeRepository/releases`

Received body:
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/releases/releases#list-releases"}
{"message":"Not Found","documentation_url":"https://docs.github.com/rest/releases/releases#list-releases","status":"404"}
The following tools were not installed:
[
"also-not-a-real-tool",
Expand Down
Loading