-
Notifications
You must be signed in to change notification settings - Fork 6
Update to CRoaring v4.2.1 for #21 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Other API's are inlined (coverage might appear on caller side). The C library has minimal coverage from this suite.
Running tests. |
test-macOS.yml is passing, but test-linux.yml has header conflicts. |
Converted PR to DRAFT. I'll stop investigating for now.
Let me know if instead you'd like to merge and possibly release, deferring CI fixes. Sorry for the noise+hassle of an incomplete PR. |
I think we ought to figure out the issue prior to merging. Do you understand the error message? Something to do with intrinsics... ? |
Sorry, I didn't realize this would result in so much CI noise in the main repo. I should probably delete the PR if/since it will take CI config fiddling to sort it out.
No, I don't understand the cause. I presume there's some delta in include processing due to different library/compiler setup, but perhaps migrating from the deprecated API bumped into the problem. Factors:
|
The problem has been reported upstream by other folks: swiftlang/swift#69311 I reproduce it with a minimal PR: #26 |
@wti Thanks for reporting the issue. CRoaring has been updated. I am closing this PR. Feel free to issue a new one. Please don't patch CRoaring here, issue a pull request upstream. |
Understood. Thank you for picking up the slack, but sorry again for breaking things. |
@wti Don't hesitate to issue another PR. |
Update to CRoaring release v4.2.1 for #21
re: Swift interface:
re: CRoaring