-
Notifications
You must be signed in to change notification settings - Fork 283
Nix flake + python package #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add a nix flake to make it easier for developers using NixOS or anyone who like a repeatable Nix based development environment. The `.envrc` is for those who use direnv, and just loads the flake. Using this a developer with nix + direnv can enter the directory, run `direnv allow .` and get a Python virtual env with everything installed and setup ready to go. Signed-off-by: David James McCorrie <djmccorrie@gmail.com>
Signed-off-by: David James McCorrie <djmccorrie@gmail.com>
Signed-off-by: David James McCorrie <djmccorrie@gmail.com>
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
Hey, thanks for the PR!
|
|
The nix flake + direnv is a standalone change that I can pull out into a separate PR. The python refactoring should just be:
I think that's it in terms of changes. The tests are still in the scripts dir, but would normally be in a If this is a direction you want to go i.e. a more standard python package that could be installed with The way to run the cli is more like a standard installed program than a "script". Although it would be easy to put back a wrapper script to fix up the docs... or I could fix up the docs to match? |
|
Thanks! Feel free to pull the Nix changes into a separate PR, as that I think I can just merge as its only introducing a new packaging variant / config file. Dont have to tho if you dont want to. |
|
I think it would be very nice to have the CLI as a python package. Once that's done, it should be fairly easy to make the CLI installable with pipx. That'd be pretty convenient, you just run As far as I can see from the pipx docs, this should be just a few lines in |
|
@felurx might be worth targeting UV instead, but as its just a python package it should work on both. |
This is probably too much in one PR, but if your interesting in going in this direction I could perhaps split this up into more incremental changes.