refactor: add janitor based cache cleanup #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently one cleanup go routine per key is created for deletion after expiration. This ensures that the keys are deleted immediately after the timer expires. But at the same time, this means a lot of goroutines. At scale this might be a problem theoretically if millions of keys accumulate.
So I want to move to a janitor based approach. The tradeoff here is that least recently used items will be evicted even if they are not expired when expired items exist. This reduces cache eviction accuracy.
Another solution on this PR can be to add a function makeSpace() which can be called instead of directly calling poptail. But this costs longer cleanup time.
So need a balance between Performance <-----> Accuracy.