-
Notifications
You must be signed in to change notification settings - Fork 392
Naive approach to handle the onPurchaseCompleted event for an offer code #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JZDesign
wants to merge
8
commits into
main
Choose a base branch
from
jzdesign/MON-1382
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot Test78 modified, 797 unchanged
🛸 Powered by Emerge Tools |
JZDesign
commented
Oct 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this is something that Tuist will help with, but I copied a file and pasted it so I could get these tests to run
rickvdl
reviewed
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
JZDesign
commented
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-android
and hybridsMotivation
We have 2 issues with how the purchase handler callbacks work that can be used in swiftUI or ReactNative.
If either of those things are true, applications that are depending on the information that comes through our
onPurchaseCompleted
callback get let down and they miss the event entirely.Description
Using a naive approach (the broadcast receiver pattern via the NotificationCenter), we enforce that all instances of the purchase handler will get all purchase events. They will be de-duplicated to ensure that we do not invoke the callback twice.