Fix dynamic type scaling for generic fonts in Paywalls #5449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dynamic Type was not working when a generic font was being used in Paywalls. According to @joshdholtz, dynamic type is supposed to be supported in Paywalls.
Description
GenericFont.makeFontto scale the font size value according to dynamic type.Note: I tried adding a Swift preview that would test that the scaling is being applied, so we could verify this behavior. But it appears that
UIFontMetrics.default.scaledValuedoesn't work in Swift Previews. 😞 So I'm open to other ideas on how to add testing for this behavior.