refactor(game): convert the achievement set tooltip cards to use BaseHoverCard #4121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I'm not sure if it's because I'm emulating mobile, but they do seem to pop sometimes - presumably dependent on how quickly the tooltip responds vs. the page turn. 2025-11-09.11-24-53.mp4 |
Member
Author
Good catch. It took a lot of clicking, but I managed to repro locally. Should be fixed now in latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates this component from
BaseTooltiptoBaseHoverCard:There shouldn't be much, if any, of a discernible difference (with the exception of you can now move your mouse into the card content).
Hover cards have different accessibility implications than tooltips: they aren't announced to screen readers and they don't pop for mobile devices. They also are more responsive when stacked next to each other horizontally. All in all, I think they're a better fit for these components.