-
Notifications
You must be signed in to change notification settings - Fork 43
Miscellaneous changes to the code #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
.NET Standard 2.0 is the earliest version that supports Memory Mapped Files. This change will improve compatibility with other projects, since it can be used in .NET Framework 4.6.1 and higher, .NET Core 2.0 and higher, and .NET 5 and higher. This change is as suggested by [Microsoft Docs](https://docs.microsoft.com/pl-pl/dotnet/standard/net-standard#which-net-standard-version-to-target).
Refactoring, naming changes, documentation,
Changes looks great, but the framework change did not seems to work for visual studio. Beside that I would like to use this as a starting point for the new client and would make changes on top of that after the tcp switch. That means I will create a new repository for this which than only contains the C#-plugin. I think that makes the most sense. So in this repository will remain the core plugin, than the c#-plugin repository to use it with c# and another for the demo. Also the action is a great start per se, but I am not sure if you pushed it to the wrong branch. I think you wanted to push that commit in your dev branch? What needs here to be done?:
Currently it is your master branch of your fork you want to merge, therefore I will hold back with commiting changes as long as you don't say anything else. Thanks for the work and fixing a lot of my errors. 😅 |
I think this was done far before the TCP migration was made, so it probably can be closed as the receiving code will also be changed. I think the best idea is to leave only the plugin in this repository, and create separate repository for code samples for each language separately, or all in one repo sorted by either directories or branches. |
Just for clarification with plugin did you mean just the c++ part making the server end getting the data from the game/sdk? I would not like to update to tcp without provide at least one working client library. |
Generally did QoL improvements, tried to refactor things and make the naming more consistent. Moved the library from .NET Framework to .NET Standard 2.0 as per Microsoft recommendations. Updated Newtonsoft.Json, added a whole lot documentation. Generally fixed almost everything that Rider complained about.
Probably a breaking change? Some properties and methods had spelling errors I fixed and extracted Wheel class from Trailer and Truck into its own class.