Skip to content

feat/AB#91885_Store-GraphQL-schema-in-public-blob-storage-file #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

estelafs
Copy link
Contributor

@estelafs estelafs commented May 3, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Screenshots

Please include screenshots of this change. If this issue is only back-end related, and does not involve any visual change of the platform, you can skip this part.

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs
Copy link
Contributor Author

estelafs commented May 6, 2024

@AntoineRelief The endpoint to get the schema url from the back-end works, but when trying to access this url in the front-end we always get a CORS error.
Could it be the case that we need to grant the url permission for redirection in the keycloack?

And the way I arranged for Apollo to use the schema file instead of the schema generated in a variable in the back in the front-end is by updating the createApollo method, but at this moment it is not possible for the front to ask the back for the url of the schema because we're not logged in yet. Is it ok if the URL with the timestamp is saved in an environment variable on the front-end?

error

@AntoineRelief AntoineRelief deleted the feat/AB#91885_Store-GraphQL-schema-in-public-blob-storage-file branch May 7, 2024 09:32
@AntoineRelief
Copy link
Collaborator

@estelafs
closing this one
It's not the way to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants