-
Notifications
You must be signed in to change notification settings - Fork 8
Ab#79314 add filters tooltips #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
… a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some updates:
- Updated translations where wrong key was used and spaces missing
- Updated incomplete code to work for time fields
@MwanPygmay the date questions type is not working, the request is never sent and we don't have a tooltiṕ, please check.
Also, @AntoineRelief Should all scalar fields have tooltips, even those that are not related to questions such as "createdBy - name"? At the moment the backend doens't return values for these kind of fields, should we add in the frontend a check to disable the tooltip and don't query the hint for these fields or add hint to all of them?
Yes, will rework on that, thanks for the translation! Mmmmh weird for the date questions, they work on my side, are you sure this is not a time question problem? EDIT: Tested, refactored back-end. Every type from numeric, text, date and time is working. The only thing is that as time is using text editor, it uses 'Examples from datasource' instead of 'Values from datasource are between', but I think the correct fix would be to have a time editor inside of the filters. |
@MwanPygmay Huum, that's weird. Here's a gif of my problem with the date type (is really a single-input question of type date): is working for the text questions, request sent etc, but when I try with the date question nothing happens, just the date format tooltip is displayed date.webm |
Indeed there is a date template in the query builder that did not get its tooltip, latest commits should fix it @estelafs |
… a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Description
Add suggestions to filters as tooltips (see screenshots).
Following fields are supported: numeric, text, time, date.
They should be supported everywhere filters are used: if data can not be acquired, check for a missing resource id, this is the most probable error source.
Time could not be tested as it has no special status in the filters.
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Created four fields from above types. Tried to go everywhere filters are used (see places where a resourceId was provided), and checked if tooltip could indeed be acquired.
Screenshots
Checklist:
( * == Mandatory )