Skip to content

Disable default features on nix crate #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hdoordt
Copy link

@hdoordt hdoordt commented Apr 9, 2025

This PR disables the default features on the nix crate. Enabling default features makes nix, and therefore anything using redis-module, require at least glibc >= 2.27 as it'll contain a reference to e.g. memfd_create. For instance, Amazon Linux 2 ships with glibc 2.26 and does not work with default features enabled.

No features are actually used by redis-module.

@DvirDukhan
Copy link
Contributor

@ephraimfeldblum LMK if it works for JSON

@ephraimfeldblum
Copy link
Contributor

ephraimfeldblum commented Apr 9, 2025

@DvirDukhan sure, no reason why JSON would object.

nix is only being used by redismodule to write to a raw fd in the event that the RedisAllocator is unavailable. write has be standardized since POSIX.1, I doubt you'll find an arch that doesn't support it.

@hdoordt
Copy link
Author

hdoordt commented Apr 14, 2025

@ephraimfeldblum @DvirDukhan Are we ready to merge this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants