Added RM_GetInternalSecret to redismodule.h #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ephraimfeldblum
approved these changes
Feb 5, 2025
MeirShpilraien
added a commit
to RedisGears/LibMR
that referenced
this pull request
Feb 5, 2025
The PR makes changes to use the internal command capabilities introduced on: redis/redis#13740. The main idea is to use the new redismodule API that provides internal secret for internal shard communication. This means that the following is no longer needed: 1. The new user configuration. 2. The internal ACL category All the commands are marked with the `internal` flag (if we see that the internal commands feature is supported on the current Redis version we run on). In addition, the connection between the shards uses `INTERNALAUTH` with the given internal secret so it can run all the internal commands. Regular user can not run any internal command. The PR require the following PR's to be merge: 1. redis/redis#13740 2. RedisLabsModules/redismodule-rs#407 The tests was modified to avoid giving password to the test module in case it detects that the internal commands feature exists. In such case, avoiding giving the password to the module, make sure that LibMR actually using the `INTERNALAUTH` command with the internal secret to authenticate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new API,
RedisModule_GetInternalSecret, introduce on redis/redis#13740 toredismodule.h.