Skip to content

add to gcc11-bullseye to workflows - [MOD-9529] #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025
Merged

add to gcc11-bullseye to workflows - [MOD-9529] #680

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
feffc3f
add to workflows
BenGoldberger May 25, 2025
6b98c5c
add to merge-queue
BenGoldberger May 25, 2025
7ba47cf
remove run from merge-to-queue
BenGoldberger May 26, 2025
1cf96ad
move flow to different file
BenGoldberger May 26, 2025
9c6e14e
check workflow
BenGoldberger May 26, 2025
33f8080
add gcc11 option
BenGoldberger May 26, 2025
3d8823f
fix nightly
BenGoldberger May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/debian11.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,9 @@ jobs:
with:
container: debian:bullseye
pre-checkout-script: apt-get update && apt-get -y install git

bullseye-gcc11:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment to the PR with a link to a successful run of this new job

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#680 (comment)

uses: ./.github/workflows/task-unit-test.yml
with:
container: gcc:11-bullseye
pre-checkout-script: apt-get update && apt-get -y install git
1 change: 1 addition & 0 deletions .github/workflows/event-merge-to-queue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
- focal
# - bionic
- bullseye
- bullseye-gcc11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have both "regular" bullseye and gcc11 bullseye on every PR merge. If you believe we need to have both flows, than let's keep it only in nightly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I wasnt sure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed it from the required jobs in the merge queue, but it will still run (the workflow of Bullseye will always run both jobs) - so I believe you have it in a separate file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I tried to add a file the event-nightly flow was angry for using too many files : here

So I added a boolean option and as you can see the merge-queue doesnt run the job here

# - amazonlinux2
- mariner2
- rocky8
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/event-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
- focal
# - bionic
- bullseye
- bullseye-gcc11
# - amazonlinux2
- mariner2
- rocky8
Expand Down