[8.0] [MOD-8244] fix TieredFactory::EstimateInitialSize #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* initailize all bf params in tiered EstimateInitialSize (metric was missing, leading to a miss computation of the components memory size estimation) * add is_normalized to EstimateComponentsMemory (passed to EstimatePreprocessorsContainerMemory) * addHNSWTieredIndexTest:: testIndexesAttributes checkes tierred index indexes attributes and componenets * remove comment (cherry picked from commit a586edf)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #569 +/- ##
=======================================
Coverage 96.93% 96.94%
=======================================
Files 100 100
Lines 5287 5297 +10
=======================================
+ Hits 5125 5135 +10
Misses 162 162 ☔ View full report in Codecov by Sentry. |
meiravgri
approved these changes
Dec 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #567 to
8.0.