format according to clang 14 #553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Our pr workflow runs on 'ubuntu-latest' image. In this workflow we also check the code format with clang-format. Diffrent clang-format versions define diffrently the "correct" format of the code.
clang-format-14 is the default version for ubuntu22.
changes in ubuntu-latest image
when
ubuntu-latestpointer was changed to ubuntu24, we merged PR #547 to format the library's code with clang-format-18, which default clang-format version of ubuntu 24.A few days later this change was rolled back and ubuntu-latest points to ubuntu22 again.
Following that we are re-formating the library with clang-format-14