Skip to content

[MOD-6775] introduce fp16 type! #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 12, 2024
Merged

[MOD-6775] introduce fp16 type! #462

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6858240
remove bw_vl arch (not needed, avx512 is enough)
meiravgri May 6, 2024
ef2c719
remove xenial from merge queue flow
meiravgri May 6, 2024
26088bf
introduce fp16 type!
meiravgri May 7, 2024
fce1754
added flow tests
meiravgri May 7, 2024
55ef50f
fp16 benchmarks
meiravgri May 8, 2024
4eb7056
fix hnsw flow test
meiravgri May 8, 2024
8cd5673
Merge branch 'meiravg_feature_bfloat16' into meiravg_fp16_vecsim_api
meiravgri May 8, 2024
29bbd7e
add float616 to serializing script
meiravgri May 8, 2024
2525371
set log call back to null in benchmarks
meiravgri May 9, 2024
ac17793
remove struct typedef
meiravgri May 9, 2024
775c41c
add comma seriaizer file
meiravgri May 10, 2024
f94d731
disable temp flow
meiravgri May 10, 2024
db2521d
disabe for real
meiravgri May 10, 2024
0edd29d
remove constexpr from bfloat default ctor
meiravgri May 11, 2024
4369584
test focal
meiravgri May 11, 2024
29c1773
disable temp flow
meiravgri May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/flow-temp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ name: temporary testing

on:
push:
branches-ignore: ['**'] # ignore all branches. Comment this line to run your workflow below on every push.
# branches-ignore: ['**'] # ignore all branches. Comment this line to run your workflow below on every push.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment


jobs:
check-if-docs-only:
uses: ./.github/workflows/task-check-docs.yml
macos:
focal:
needs: [check-if-docs-only]
if: ${{ needs.check-if-docs-only.outputs.only-docs-changed == 'false' }}
uses: ./.github/workflows/task-unit-test.yml
with:
env: macos-latest
run-valgrind: false
container: ubuntu:focal
2 changes: 1 addition & 1 deletion src/VecSim/types/bfloat16.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
namespace vecsim_types {
struct bfloat16 {
uint16_t val;
constexpr bfloat16() = default;
bfloat16() = default;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a compiler version issue? How come it works with fp16? Can we try this option?

Suggested change
bfloat16() = default;
constexpr bfloat16() noexcept {}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

declaring a default ctor as constexpr is allowed as of c++20, and this feature in particular is supported as of gcc10
fp16 worked because it didn't have constexpr at first place.
Anyway, since we have another ctor that is constexpr, it doesn't matter.

constexpr bfloat16(uint16_t val) : val(val) {}
operator uint16_t() const { return val; }
};
Expand Down
Loading