OSIDB-3852: Require internal comment on Incident request #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jincxz
force-pushed
the
OSIDB-3959-update-incident-state-field
branch
2 times, most recently
from
c1807ef to
ef3eb98
Compare
Base automatically changed from
OSIDB-3959-update-incident-state-field
to
affects-v2
October 29, 2025 15:57
Elkasitu
force-pushed
the
required-comment-on-incident-request
branch
from
973a701 to
58c2ea8
Compare
When requesting an incident on a Flaw, users will now be required to submit a comment denoting why they think the Flaw constitutes an incident. Closes OSIDB-3852
Elkasitu
force-pushed
the
required-comment-on-incident-request
branch
from
58c2ea8 to
48c346c
Compare
JakubFrejlach
approved these changes
Oct 30, 2025
Comment on lines
+13033
to
+13063
| deprecated: true | ||
| oneOf: | ||
| - $ref: '#/components/schemas/MajorIncidentStateEnum' | ||
| - $ref: '#/components/schemas/BlankEnum' | ||
| major_incident_start_dt: | ||
| type: string | ||
| format: date-time | ||
| nullable: true | ||
| nist_cvss_validation: | ||
| oneOf: | ||
| - $ref: '#/components/schemas/NistCvssValidationEnum' | ||
| - $ref: '#/components/schemas/BlankEnum' | ||
| aegis_meta: {} | ||
| embargoed: | ||
| type: boolean | ||
| description: The embargoed boolean attribute is technically read-only as | ||
| it just indirectly modifies the ACLs but is mandatory as it controls the | ||
| access to the resource. | ||
| group_key: | ||
| type: string | ||
| maxLength: 60 | ||
| owner: | ||
| type: string | ||
| maxLength: 60 | ||
| team_id: | ||
| type: string | ||
| maxLength: 8 | ||
| required: | ||
| - comment_zero | ||
| - embargoed | ||
| - title |
There was a problem hiding this comment.
I wonder where this change came from? 🤔 Only thing which changed for FlawPostSerializer was deprecate_fields=["major_incident_state"]
There was a problem hiding this comment.
I think it's just an artifact from the diff algorithm, since I introduce a FlawPutSerializer and the contents are pretty similar
|
|
||
| @extend_schema_serializer(exclude_fields=["updated_dt"]) | ||
| @extend_schema_serializer( | ||
| exclude_fields=["updated_dt"], deprecate_fields=["major_incident_state"] |
There was a problem hiding this comment.
I suppose later we will just move major_incident_state to exclude_fields? 🤔
There was a problem hiding this comment.
yes, the field will be read-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting an incident on a Flaw, users will now be required to submit a comment denoting why they think the Flaw constitutes an incident.
Closes OSIDB-3852
Depends on #1087