Skip to content

Conversation

sarroutbi
Copy link
Contributor

@sarroutbi sarroutbi commented Oct 17, 2025

Summary by Sourcery

Tests:

  • Replace rlWaitForCmd 'tail $(limeVerifierLogfile) | grep -q ...' with grep -q ... $(limeVerifierLogfile) to more reliably detect the agent API version update message

Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
Copy link

sourcery-ai bot commented Oct 17, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The pull request refines the test script’s log search by removing the tail command and applying grep directly on the full verifier log, ensuring the agent API version update message is detected reliably.

File-Level Changes

Change Details Files
Search entire verifier log for API version update message
  • Removed the tail command that limited the search to the log’s end
  • Changed rlWaitForCmd invocation to run grep -q directly on the full logfile
  • Updated quoting to match the new grep call
compatibility/basic-attestation-on-localhost-api-version-bump/test.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kkaarreell kkaarreell merged commit 7556109 into RedHat-SP-Security:main Oct 17, 2025
10 checks passed
@sarroutbi sarroutbi deleted the 202510171003-search-agent-version-update-in-whole-log branch October 20, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants