GitHub Actions: Run pre-commit #74
Conversation
| import unittest | ||
|
|
||
| import numpy as np | ||
|
|
There was a problem hiding this comment.
This is a problem: when I run pre-commit run --all-files on my machine, or isort directly, this change gets undone.
The problem is that soundswallower is an internal module, and therefore there's a space between third party import (numpy) and internal imports, but pre-commit-action is not recognizing that here, it's lumping soundswallower with the third party imports.
Maybe a pip install -e . is required first?
There was a problem hiding this comment.
OK... Let's try that. There is also the idea of isort known-first-party in the config but I like your idea more.
There was a problem hiding this comment.
I suppose for just running isort, it's silly to install everything.
I was going to vote against known-first-party because I think isort ought to be able to figure it out, but for performance reasons I have changed my mind.
2 participants
PR Goal?
Run the pre-commit tests in GitHub Actions to catch issues from users who do not have pre-commit installed locally.
Fixes?
Feedback sought?
Priority?
Tests added?
How to test?
Confidence?
Version change?